Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(snapshot): refactor -t to -o #773

Merged
merged 3 commits into from
May 2, 2022
Merged

chore(snapshot): refactor -t to -o #773

merged 3 commits into from
May 2, 2022

Conversation

louis-bompart
Copy link
Collaborator

@louis-bompart louis-bompart commented Apr 28, 2022

https://coveord.atlassian.net/browse/CDX-944

Proposed changes

Rename --target/-t to --organization/-o

Breaking changes

--target and -t are removed. Considered OK because of the beta tag.

Testing

  • Unit Tests:
  • Functionnal Tests:
  • Manual Tests:

@github-actions
Copy link
Contributor

Thanks for your contribution @louis-bompart !
When your pull-request is ready to be merged, check the box below to merge it

  • Merge! :shipit:

@github-actions
Copy link
Contributor

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

@louis-bompart louis-bompart merged commit 65aa4e7 into master May 2, 2022
@louis-bompart louis-bompart deleted the CDX-944 branch May 2, 2022 23:43
@louis-bompart louis-bompart mentioned this pull request May 3, 2022
2 tasks
@y-lakhdar y-lakhdar mentioned this pull request Dec 20, 2022
3 tasks
louis-bompart added a commit that referenced this pull request Jan 12, 2023
https://coveord.atlassian.net/browse/CDX-1251

<!-- For Coveo Employees only. Fill this section.

CDX-XXX

-->

## Proposed changes

Missing change from #773 

<!--
    Remove this section if the PR does not include any breaking change

If your changes includes some breaking changes in the code, thoroughly
explains:
        - What are the breaking changes programmatically speaking.
- What is the impact on the end-user (e.g. user cannot do X anymore).
        - What motivates those changes.
-->

## Testing

- [ ] Unit Tests:
<!-- Did you write unit tests for your feature? If not, explains why?
-->
- [ ] Functionnal Tests:
<!-- Did you write functionnal tests for your feature? If not, explains
why? -->
- [ ] Manual Tests:
<!-- How did you test your changeset?  -->

Co-authored-by: Louis Bompart <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants