fix(create-atomic): prevent Atomic/Headless version mismatch & use installed Atomic version #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThibodeauJF
requested review from
olamothe,
y-lakhdar and
louis-bompart
as code owners
|
Thanks for your contribution @ThibodeauJF !
|
ThibodeauJF
commented
Apr 12, 2022
ThibodeauJF
commented
Apr 12, 2022
ThibodeauJF
commented
Apr 12, 2022
|
Pull Request Report PR Title ✅ Title follows the conventional commit spec. |
ThibodeauJF
commented
Apr 12, 2022
Nah should be fine, or just add a subtask on the KIT Jira. |
louis-bompart
approved these changes
Apr 13, 2022
…stalled Atomic version
olamothe
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CDX-XXX 😢 want me to create a JIRA in this project instead?
https://coveord.atlassian.net/browse/KIT-1515
Proposed changes
some general context here coveo/ui-kit#1885
Breaking changes
None, only for new CLI generated projects
Testing
Current tests should still pass