Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): major dep updates + react 17 lock #730

Merged
merged 2 commits into from
Mar 30, 2022
Merged

Conversation

louis-bompart
Copy link
Collaborator

https://coveord.atlassian.net/browse/CDX-895

Proposed changes

  • Add React to template.json dependencies: This ensures CRA doesn't go too yolo and start using React 18 (which MUI ain't supporting).
  • Run the codemod for mui 4->5, it checks out.

Notable changes

Well, new MUI version, the UI might change a bit (i.e. outlined now the standard, soo). But the UX should be the same
TL;DR: Different look, same feel.

Testing

  • Manual test w/ Verdaccio
  • CI yolo for E2E (they're already brokey rn so, if green then gg.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 29, 2022

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

@louis-bompart louis-bompart changed the title fix(react): major dep updates + react 17 lock. fix(react): major dep updates + react 17 lock Mar 29, 2022
@louis-bompart louis-bompart merged commit b7de6b2 into master Mar 30, 2022
@louis-bompart louis-bompart deleted the CDX-895 branch March 30, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants