fix(cli): no more patches bundled #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need it.
|
Thanks for your contribution @louis-bompart !
|
|
Pull Request Report PR Title ✅ Title follows the conventional commit spec. |
olamothe
approved these changes
Feb 1, 2022
|
You have tested that when you run the executable, the patches are correctly applied ? I vaguely remember that's why they were there. Not for the version of the CLI that you run or install through npm. |
y-lakhdar
approved these changes
Feb 1, 2022
|
The oclifdev-cli is only used during the build binaries pipeline, never in the source code, even transitively :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
After analyzing our latest release tarball https://registry.npmjs.org/@coveo/cli/-/cli-1.24.1.tgz, I found that the patch was bundle due to a change of name when I updated the patch.
However, since adding the filter for 'dev' patches, we removed all our other patches. So let's remove patches altogether, it'll be simpler.
Testing
Need to release.
CDX-786