feat(cli): extract user email from oauth flow #48
Conversation
|
Pull Request Report PR Title ✅ Title follows the conventional commit spec. |
I don't think so. The decorator pattern can be nice when we know it's going to be re-used in a ton of different command (like, most command 99% will require the user to be connected, so I think it makes sense in that case). Decorators have the drawback of being harder to read/maintain/not as easy to debug. We should be careful not to be sprinkling them everywhere. A good ol' function is just generally much more straightforward to reason about. |
| private async getUserInfo() { | ||
| const authenticatedClient = new AuthenticatedClient(); | ||
| const platformClient = await authenticatedClient.getClient(); | ||
| await platformClient.initialize(); |
There was a problem hiding this comment.
We could add a method on AuthenticatedClient called getUserInfo that abstract line 91/92 .
There was a problem hiding this comment.
I agree. Pretty sure, we will use it elsewhere.
I'm creating a JIRA
Not sure if a decorator would be more appropriate here...