Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): typescript issues #459

Merged
merged 2 commits into from
Sep 7, 2021
Merged

fix(cli): typescript issues #459

merged 2 commits into from
Sep 7, 2021

Conversation

louis-bompart
Copy link
Collaborator

@louis-bompart louis-bompart commented Sep 7, 2021

Proposed changes

  • Fix the TypeScript issue that came up on the build.
  • Ensure we use the TypeScript version specified in the package.json

What was going on.

TL;DR: TypeScript released the 4.4 version, which introduced some changes that broke our build (more details below) and, unbeknown to us, we were using the 'global' TypeScript that ship with the virtual-environment, not the one that we version in our package.json, which lead to the error appearing outta thin air without any incriminating changeset.

This PR change that by using the node_modules/.bin to prevent uncontrolled update of TypeScript.

Long version:

  • Aug 26th: Microsoft promotes 4.4.2 from RC to latest tag.
  • Aug 31st: GitHub creates the first new release of ubuntu-latest virtual environment since the 26th.
  • Sept 2nd: First build to uses the new environment. The 1d delay is hypothetically due to rollout time etc on GitHub side. The issue stays undetected on our side until this build because all build priors did not reach the build stage.

Testing

  • Automated Test: Ensure commands acquire specific tsconfig.json to be certain it runs proper.
  • Manual Tests: tsc on my WSL and Windows env.

Future improvements:

  • Add daily build to SAN-check our processes.

CDX-569

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants