Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add repository key on search-token-server #445

Merged
merged 3 commits into from
Aug 25, 2021
Merged

Conversation

y-lakhdar
Copy link
Contributor

https://coveord.atlassian.net/browse/CDX-547

Proposed changes

Just to prevent the following warning:

Created git commit.

›   Warning: 
›         An unknown error occurred while trying to copy the search token server. Please refer to cdx545/README.md for more information.
›         npm notice created a lockfile as package-lock.json. You should commit this file.
›   npm WARN @coveo/[email protected] No repository field.
›
›
›      

Testing

Pretty straight forward... not sure we need tests for that

  • Unit Tests:
  • Functionnal Tests:
  • Manual Tests:

Copy link
Collaborator

@louis-bompart louis-bompart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm overall:

  • changes scope to 'fix': it fixes an issue, so it's a fix ;)
  • add directory field

@y-lakhdar y-lakhdar changed the title chore: add repository key on search-token-server fix: add repository key on search-token-server Aug 25, 2021
@louis-bompart louis-bompart merged commit f1f0034 into master Aug 25, 2021
@louis-bompart louis-bompart deleted the CDX-547 branch August 25, 2021 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants