fix(vue): support project creation with Node 16 and pnpm #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y-lakhdar
commented
Jul 30, 2021
| @@ -143,7 +143,7 @@ export default class Vue extends Command { | |||
| // user: providerUsername, | |||
| // }, | |||
| }, | |||
| cssPreprocessor: 'node-sass', | |||
| cssPreprocessor: 'sass', | |||
There was a problem hiding this comment.
Node Sass causes some errors on the pnpm installation.
Node Sass is deprecated anyway.
| @@ -12,11 +12,15 @@ module.exports = (api, options, rootOptions) => { | |||
| '@coveo/headless': '*', | |||
| '@coveo/search-token-server': '*', | |||
| buefy: '^0.9.4', | |||
| bulma: '^0.9.3', | |||
| concurrently: '^5.3.0', | ||
| dotenv: '^9.0.2', | ||
| 'get-port': '^5.1.1', | ||
| 'fs-extra': '^10.0.0', | ||
| }, | ||
| devDependencies: { | ||
| tslib: '^2.3.0', |
There was a problem hiding this comment.
Same thing as above.
tslib should be added by @vue/cli, when using a typescript preset.
| @@ -27,6 +27,7 @@ function copySearchTokenServerToRoot() { | |||
| resolve('server'), | |||
| { | |||
| filter: (src, dest) => !isNodeModule(dest) && !isEnvFile(dest), | |||
| dereference: true, | |||
There was a problem hiding this comment.
Because pnpm does some kind of symlink magic
louis-bompart
approved these changes
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://coveord.atlassian.net/browse/CDX-520
Proposed changes
Creating a VueJs project with Node 16 and pnpm causes the following error
CDX-520