fix(snapshot): pull should use new enum #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ResourceSnapshotContentType is the new enum fix https://coveord.atlassian.net/browse/CDX-485
y-lakhdar
approved these changes
Jul 21, 2021
y-lakhdar
requested changes
Jul 21, 2021
y-lakhdar
approved these changes
Jul 21, 2021
olamothe
approved these changes
Jul 21, 2021
louis-bompart
added a commit
that referenced
this pull request
Aug 9, 2021
* draft 01 https://coveord.atlassian.net/browse/CDX-347 * better merging https://coveord.atlassian.net/browse/CDX-347 * strong type https://coveord.atlassian.net/browse/CDX-347 * refresh PR https://coveord.atlassian.net/browse/CDX-347 * ironing merge https://coveord.atlassian.net/browse/CDX-347 * Working (with #365) https://coveord.atlassian.net/browse/CDX-347 * smoothing up - muffle the gits - ensure that ye old preview are yeeted out. * prettier * lint https://coveord.atlassian.net/browse/CDX-347 * spec * add epoch sort + ut on old preview deletion https://coveord.atlassian.net/browse/CDX-347 * viewer->previewer https://coveord.atlassian.net/browse/CDX-347 * jsdoc https://coveord.atlassian.net/browse/CDX-347 * UT progress https://coveord.atlassian.net/browse/CDX-347 * refactor file diff processor https://coveord.atlassian.net/browse/CDX-347 * adapt test for refactor https://coveord.atlassian.net/browse/CDX-347 * prepare UT for filesDiffProcessor https://coveord.atlassian.net/browse/CDX-347 * rework filesDiffProcessor * UT complete https://coveord.atlassian.net/browse/CDX-347 * tweak code for project change https://coveord.atlassian.net/browse/CDX-347 * Update expandedPreviewer.spec.ts * handle project absolute path v. relative path in exp preview * skip delete if no preview dir https://coveord.atlassian.net/browse/CDX-347 Co-authored-by: Yassine <[email protected]>
louis-bompart
added a commit
that referenced
this pull request
Aug 10, 2021
* draft 01 https://coveord.atlassian.net/browse/CDX-347 * better merging https://coveord.atlassian.net/browse/CDX-347 * strong type https://coveord.atlassian.net/browse/CDX-347 * refresh PR https://coveord.atlassian.net/browse/CDX-347 * ironing merge https://coveord.atlassian.net/browse/CDX-347 * Working (with #365) https://coveord.atlassian.net/browse/CDX-347 * smoothing up - muffle the gits - ensure that ye old preview are yeeted out. * prettier * lint https://coveord.atlassian.net/browse/CDX-347 * spec * add epoch sort + ut on old preview deletion https://coveord.atlassian.net/browse/CDX-347 * viewer->previewer https://coveord.atlassian.net/browse/CDX-347 * jsdoc https://coveord.atlassian.net/browse/CDX-347 * UT progress https://coveord.atlassian.net/browse/CDX-347 * refactor file diff processor https://coveord.atlassian.net/browse/CDX-347 * adapt test for refactor https://coveord.atlassian.net/browse/CDX-347 * prepare UT for filesDiffProcessor https://coveord.atlassian.net/browse/CDX-347 * rework filesDiffProcessor * UT complete https://coveord.atlassian.net/browse/CDX-347 * tweak code for project change https://coveord.atlassian.net/browse/CDX-347 * Update expandedPreviewer.spec.ts * handle project absolute path v. relative path in exp preview * skip delete if no preview dir https://coveord.atlassian.net/browse/CDX-347 * temporary * ut and polish Co-authored-by: Yassine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Updated which enum to use, see coveo/platform-client#351
Testing
Manual test. The command goes kaboom without the changes.
CDX-485