Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(push): fix incorrect types for timestamp when using delete older than #363

Merged
merged 4 commits into from
Jul 20, 2021

Conversation

olamothe
Copy link
Member

Proposed changes

Fix issue when doing deleteOlderThan using timestamp

Testing

  • Unit Tests:
  • Manual Tests:

https://coveord.atlassian.net/browse/CDX-477

Copy link
Collaborator

@louis-bompart louis-bompart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.
Added my two-cents on the regex thread.
I would prefer a ternary for the number/NaN branching, to avoid code repetition.

@olamothe olamothe merged commit 41030d4 into master Jul 20, 2021
@louis-bompart louis-bompart deleted the CDX-477 branch July 29, 2021 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants