feat(push): add support for very large batch of documents #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olamothe
commented
Jul 20, 2021
| @@ -154,4 +172,61 @@ export default class SourcePushAdd extends Command { | |||
| ); | |||
| throw err; | |||
| } | |||
|
|
|||
| private splitByChunkAndUpload( | |||
There was a problem hiding this comment.
The main function of this PR:
Create and return two function:
- One to push documents (send) which accumulate documents until they reach a maxContentLength size. When the limit is reached, push the documents to Coveo (
uploadBatchfunction). - One to "close" when there's no more files to parse and convert to
DocumentBuilder, so that we can flush the remaining queue (remaining documents inaccumulator.chunks)
y-lakhdar
approved these changes
Jul 20, 2021
| @@ -154,4 +172,61 @@ export default class SourcePushAdd extends Command { | |||
| ); | |||
| throw err; | |||
| } | |||
|
|
|||
| private splitByChunkAndUpload( | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Rework upload command to split by chunks manageable by the Push API.
I was able to test and push ~500k documents in a source in a couple of seconds (have the documents accepted by the Push API).
The end result for the user is something like this:
☝️ Pushing a folder with 2 files (both of them have the same number of documents because it is fake data).
Users don't have to worry about splitting the size of their files or how many documents there are, it should all be handled automatically for them.
Testing
https://coveord.atlassian.net/browse/CDX-471