fix(analytics): fix analytics hook for expired or logged out #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pull Request Report PR Title ✅ Title follows the conventional commit spec. |
louis-bompart
requested changes
Feb 15, 2021
louis-bompart
requested changes
Feb 16, 2021
louis-bompart
requested changes
Feb 23, 2021
| mockedAuthenticationStatus.mockImplementationOnce(() => | ||
| Promise.resolve(AuthenticationStatus.EXPIRED) | ||
| ); | ||
| expect(async () => await hook(getAnalyticsHook({}))).not.toThrow(); |
There was a problem hiding this comment.
If you uses async/await, follow closely what's in https://jestjs.io/docs/en/asynchronous.
So here it should be
Suggested change
| expect(async () => await hook(getAnalyticsHook({}))).not.toThrow(); | |
| await expect(() => hook(getAnalyticsHook({})))..resolves.not.toThrow(); |
I removed the async/await inside because they were not necessary, because hook is returning a promise.
The important await is in the call back of the it statement :)
Co-authored-by: Louis Bompart <[email protected]>
louis-bompart
requested changes
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://coveord.atlassian.net/browse/CDX-84