-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): expanded preview #267
Conversation
- muffle the gits - ensure that ye old preview are yeeted out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@louis-bompart : Are these changes ready to review and merge ?
I saw your last comment about the backend not being ready and you preferring to wait. If that's the case, can you close this temporarily and re-open when it's ready (or switch it to draft).
Thanks !
@olamothe, the PR description is up-to-date with the work that I think needs to be done (mainly, UT), but it is ready for review.
I don't know which comment you are talking about 😕? |
This one:
But if it's ready, then 👍 Ill do the review. |
Ready for full review. Incorporate part of #391 and needs it to be merged first |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GG.
Maybe another to add a spinner while computing the expanded preview
Proposed changes
When previewing, being it thru the dedicated command or part of the
push
flow allow the user to analyze files to preview what's what.To be precise:
-d
flag.Testing
The focus of the tests will be on UT for this, testing is still ongoing:
CDX-347