Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add push command #260

Merged
merged 140 commits into from
Jun 21, 2021
Merged

feat: add push command #260

merged 140 commits into from
Jun 21, 2021

Conversation

y-lakhdar
Copy link
Contributor

@y-lakhdar y-lakhdar commented Jun 12, 2021

Proposed changes

Add a command to apply a snapshot to an organization. It uses the same flow as the preview command and prompt a message to the user asking to apply the changes.

The user needs to approve for the snapshot to be applied.

Example:
image

Testing

  • Unit Tests:
  • Functionnal Tests:
  • Manual Tests:

CDX-348

@y-lakhdar y-lakhdar changed the base branch from CDX-389 to CDX-361 June 16, 2021 18:56
@y-lakhdar y-lakhdar changed the base branch from CDX-361 to master June 17, 2021 20:41
@y-lakhdar y-lakhdar marked this pull request as ready for review June 17, 2021 20:42
Copy link
Collaborator

@louis-bompart louis-bompart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, would move the snapshot URL functions in another file, other than that gg!

packages/cli/src/lib/platform/environment.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@louis-bompart louis-bompart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

packages/cli/src/lib/platform/url.ts Outdated Show resolved Hide resolved
@louis-bompart
Copy link
Collaborator

As mentioned in #274, I would have the UT in this PR, even if it's a bit bulky.
The reasoning behind that is it's way easier to review a PR with the code and the test together ;)

@y-lakhdar y-lakhdar merged commit 25b8c6c into master Jun 21, 2021
@louis-bompart louis-bompart deleted the CDX-348 branch July 29, 2021 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants