Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: setup a synchronization plan if the resources are in error #248

Merged
merged 70 commits into from
Jun 9, 2021

Conversation

y-lakhdar
Copy link
Contributor

@y-lakhdar y-lakhdar commented Jun 6, 2021

Proposed changes

If the snapshot and the target organization are not in sync, the command will print an URL to the Admin Console so the user can synchronize his organization.
The CLI is not handling any synchronization logic at the moment.

Testing

  • Unit Tests:
  • Functionnal Tests:
  • Manual Tests:

CDX-370

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2021

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

@y-lakhdar y-lakhdar changed the title feat: Setup a synchronization plan if the resources are in error feat: setup a synchronization plan if the resources are in error Jun 6, 2021
@y-lakhdar y-lakhdar marked this pull request as ready for review June 7, 2021 17:11
Copy link
Collaborator

@louis-bompart louis-bompart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good!
I tagged @jpmarceau 'cause I ain't sure about the message tho

packages/cli/src/commands/org/config/preview.ts Outdated Show resolved Hide resolved
packages/cli/src/commands/org/config/preview.ts Outdated Show resolved Hide resolved
packages/cli/src/lib/snapshot/snapshot.ts Outdated Show resolved Hide resolved
Copy link
Member

@olamothe olamothe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 !

@y-lakhdar y-lakhdar merged commit 2077d9c into master Jun 9, 2021
@louis-bompart louis-bompart deleted the CDX-370 branch July 29, 2021 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants