Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): set dependency and cd fix #223

Merged
merged 2 commits into from
May 14, 2021
Merged

fix(cli): set dependency and cd fix #223

merged 2 commits into from
May 14, 2021

Conversation

louis-bompart
Copy link
Collaborator

Proposed changes

Lerna was resetting the package.json before we commit, which is not what we want at all.

  • Band-aid: put back the proper version
  • Tell lerna to just no do that.

Testing

  • Manual Tests: Tried with Verdaccio several times.

CDX-328

@github-actions
Copy link
Contributor

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

@louis-bompart louis-bompart merged commit 3a89594 into master May 14, 2021
@louis-bompart louis-bompart deleted the CDX-328 branch July 29, 2021 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants