Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(angular): create an angular schematic #19

Merged
merged 11 commits into from
Feb 11, 2021
Merged

feat(angular): create an angular schematic #19

merged 11 commits into from
Feb 11, 2021

Conversation

y-lakhdar
Copy link
Contributor

With angular schematics we can define templates to generate entire Angular project or simply inject specific elements (like the Headless Engine and its dependencies) to an existing Angular project.

The @coveo/angular schematic can also be used on its own with the Angular CLI.

So if you want to set up a Coveo search page in an existing Angular project, you would just do
ng add @coveo/angular --orgId<org-id> --apiKey=<api-key>

Eventually, the feature CDX-49 will leverage that into the @coveo/cli as a specific command

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2021

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Copy link
Member

@olamothe olamothe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you said, there's plenty of boilerplate with angular... 🤷

packages/angular/src/schema.json Show resolved Hide resolved
packages/angular/tsconfig.json Show resolved Hide resolved
Copy link
Collaborator

@louis-bompart louis-bompart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't have time to check in detail the angular schematic things, however, I did spot an issue with path and Windows :)

packages/angular/src/rules/ng-module.ts Outdated Show resolved Hide resolved
packages/angular/src/rules/ng-module.ts Outdated Show resolved Hide resolved
packages/angular/src/rules/ng-module.ts Outdated Show resolved Hide resolved
packages/angular/src/rules/ng-module.ts Outdated Show resolved Hide resolved
packages/angular/src/rules/templates.ts Show resolved Hide resolved
packages/angular/src/rules/templates.ts Show resolved Hide resolved
Copy link
Collaborator

@louis-bompart louis-bompart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes, LGTM overall 👍

packages/angular/src/rules/ng-module.ts Outdated Show resolved Hide resolved
packages/angular/package.json Outdated Show resolved Hide resolved
@y-lakhdar y-lakhdar merged commit 38aef0f into master Feb 11, 2021
@louis-bompart louis-bompart deleted the CDX-50 branch June 7, 2021 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants