feat(cli): fix linting in vue project and rework headless initialization #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rebased PR on vue-lint to ensure we're greenlit on all sides. - Add vetur.config.js to allow the use of vetur in a monorepo context - Disabled node/no-unpublished-import for vue: We need to import devDeps for typechecking because the template is installing them on the fly. (already done on angular and react) - Removed declaration: Cannot overrride typing of Vue $root (or at least I didn't find how) - Morphed isEnvValid into a type-guard - Smite all non-null assertion operators - And err the big one: Reworked all comps': they now instantiate their state in the data, because it makes so much more sense considering Vue life-cycle. To that end: the global mixin now instead does a `beforeCreate` that write in the data of the root component. Inspired from https://vuejs.org/v2/guide/state-management.html#Simple-State-Management-from-Scratch - Validate type check, both in our and in the enduser code (i.e. our linter is happy, and vue's one happy too) https://coveord.atlassian.net/browse/CDX-180
|
Pull Request Report PR Title ✅ Title follows the conventional commit spec. |
Closed
louis-bompart
removed
the
do not merge
y-lakhdar
approved these changes
Apr 14, 2021
| /** | ||
| * Making sure all environment variables are defined | ||
| * | ||
| * @returns true if the .env file is valid. false otherwise. | ||
| */ | ||
| export function isEnvValid() { | ||
| export function isEnvValid(env: NodeJS.ProcessEnv): env is ValidEnvironment { |
There was a problem hiding this comment.
Nice. Did not know about that. Super useful
| <script lang="ts"> | ||
| import Vue from 'vue'; | ||
|
|
||
| export default Vue.extend({ | ||
| name: 'FacetValue', | ||
| props: ['facetValue'], |
There was a problem hiding this comment.
It's a shame we can't have prop types for custom object...
| Vue.mixin(engineService.mixin); | ||
| const engine = getEngine(token); | ||
| Vue.mixin({ | ||
| beforeCreate: function () { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OG PR is #149 differences are:
The 🥖commit:
isEnvValidinto a type-guardTo that end: the global mixin now instead does a
beforeCreatethat writes in the data of the root component. Inspired from https://vuejs.org/v2/guide/state-management.html#Simple-State-Management-from-Scratchhttps://coveord.atlassian.net/browse/CDX-180