fix(atomic): remove spinner in atomic:cmp
#1291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louis-bompart
requested review from
olamothe,
y-lakhdar and
btaillon-coveo
and removed request for
a team
louis-bompart
changed the title
atomic:cmp
|
Thanks for your contribution @louis-bompart !
|
|
Pull Request Report PR Title ✅ Title follows the conventional commit spec. |
y-lakhdar
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Before:
On first usage, users may need to confirm that yes they are OK installing the init package. However the spinner mangle the stdio, making it hard for the user to proceed.
Testing
corner case really.
/bin/devtested, see