fix(atomic): wait for atomic to load/init on page component #1284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louis-bompart
requested review from
olamothe,
y-lakhdar and
mrrajamanickam-coveo
and removed request for
a team
|
Thanks for your contribution @louis-bompart !
|
|
Pull Request Report PR Title ✅ Title follows the conventional commit spec. |
y-lakhdar
requested changes
Apr 20, 2023
...ic/create-atomic-component/template/src/components/sample-component/src/sample-component.tsx
Show resolved
Hide resolved
y-lakhdar
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The initializeBindings fail without the preliminary await
Testing
Tricky, I don't know how to do an automated test for that.
My test is: