fix(cli-commons): color orgId magenta only when on unix or WT #1143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louis-bompart
requested review from
olamothe,
ThibodeauJF and
btaillon-coveo
and removed request for
a team
|
Thanks for your contribution @louis-bompart !
|
|
Pull Request Report PR Title ✅ Title follows the conventional commit spec. |
btaillon-coveo
approved these changes
Mar 10, 2023
louis-bompart
commented
Mar 10, 2023
y-lakhdar
pushed a commit
that referenced
this pull request
Mar 16, 2023
https://coveord.atlassian.net/browse/CDX-1365 ## Proposed changes Some color doesn't work nicely on PS, so let's just skip'em'. Windows users should use WT if they want niceties. ## Testing - [x] Unit Tests - [x] Manual Tests: `packages\cli\core\bin\dev auth:login` with powershell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://coveord.atlassian.net/browse/CDX-1365
Proposed changes
Some color doesn't work nicely on PS, so let's just skip'em'.
Windows users should use WT if they want niceties.
Testing
packages\cli\core\bin\dev auth:loginwith powershell