Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deploy): add new (but hidden) deploy command #1099

Merged
merged 28 commits into from
Feb 20, 2023
Merged

Conversation

ThibodeauJF
Copy link
Contributor

@ThibodeauJF ThibodeauJF commented Feb 9, 2023

KIT-2268

Proposed changes

Design Doc

Takes a JSON config, validates it, reads the necessary files and uploads to whole to the new service.

Breaking changes

New!

Testing

All automated forms of tests will come soon.

  • Manual Tests:

Creation

Screen Shot 2023-02-09 at 2 22 04 PM

Screen Shot 2023-02-09 at 2 22 52 PM

Update

Screen Shot 2023-02-09 at 2 47 55 PM

Screen Shot 2023-02-09 at 2 42 37 PM

@ThibodeauJF ThibodeauJF marked this pull request as ready for review February 9, 2023 20:02
@ThibodeauJF ThibodeauJF requested a review from a team as a code owner February 9, 2023 20:02
@ThibodeauJF ThibodeauJF requested review from olamothe, y-lakhdar, btaillon-coveo and louis-bompart and removed request for a team February 9, 2023 20:02
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2023

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Copy link
Contributor

@btaillon-coveo btaillon-coveo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jpmarceau jpmarceau removed the request for review from srosenberg-coveo February 10, 2023 14:27
Copy link
Contributor

@jpmarceau jpmarceau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ThibodeauJF ThibodeauJF merged commit 2080adb into master Feb 20, 2023
@ThibodeauJF ThibodeauJF deleted the KIT-2268 branch February 20, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants