-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(deploy): add new (but hidden) deploy command #1099
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Report PR Title ✅ Title follows the conventional commit spec. |
ThibodeauJF
commented
Feb 9, 2023
ThibodeauJF
commented
Feb 9, 2023
btaillon-coveo
approved these changes
Feb 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
jpmarceau
approved these changes
Feb 10, 2023
Co-authored-by: jpmarceau <[email protected]> Co-authored-by: Benjamin Taillon <[email protected]>
y-lakhdar
reviewed
Feb 14, 2023
ThibodeauJF
commented
Feb 14, 2023
jpmarceau
approved these changes
Feb 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Co-authored-by: jpmarceau <[email protected]>
y-lakhdar
approved these changes
Feb 14, 2023
louis-bompart
approved these changes
Feb 16, 2023
This reverts commit 626d32a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KIT-2268
Proposed changes
Design Doc
Takes a JSON config, validates it, reads the necessary files and uploads to whole to the new service.
Breaking changes
New!
Testing
All automated forms of tests will come soon.
Creation
Update