-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate to Atomic V2 #1074
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThibodeauJF
requested review from
olamothe,
y-lakhdar and
louis-bompart
as code owners
December 16, 2022 17:27
Thanks for your contribution @ThibodeauJF !
|
Pull Request Report PR Title ✅ Title follows the conventional commit spec. |
olamothe
approved these changes
Jan 4, 2023
louis-bompart
approved these changes
Jan 9, 2023
ThibodeauJF
changed the title
feat(create-atomic): migrate to Atomic V2
feat: migrate to Atomic V2
Jan 11, 2023
btaillon-coveo
approved these changes
Jan 12, 2023
Co-authored-by: Louis Bompart <[email protected]>
louis-bompart
force-pushed
the
CDX-1281
branch
from
January 12, 2023 16:32
5af223d
to
196d28f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://coveord.atlassian.net/browse/CDX-1281
Proposed changes
Migrates the generated Atomic project to use Atomic v2
Breaking changes
All the v2 breaking changes are included. We should time the release of this feature shortly after the HSP (on https://github.com/coveo/search-interface-service) has done its Atomic V2 migration. If users download an HSP using Atomic v2 without upgrading the CLI, they will have to migrate the local project themselves.
Testing