Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate to Atomic V2 #1074

Merged
merged 14 commits into from
Jan 12, 2023
Merged

feat: migrate to Atomic V2 #1074

merged 14 commits into from
Jan 12, 2023

Conversation

ThibodeauJF
Copy link
Contributor

@ThibodeauJF ThibodeauJF commented Dec 16, 2022

https://coveord.atlassian.net/browse/CDX-1281

Proposed changes

Migrates the generated Atomic project to use Atomic v2

Breaking changes

All the v2 breaking changes are included. We should time the release of this feature shortly after the HSP (on https://github.com/coveo/search-interface-service) has done its Atomic V2 migration. If users download an HSP using Atomic v2 without upgrading the CLI, they will have to migrate the local project themselves.

Testing

  • Unit Tests:
  • Functionnal Tests:
  • Manual Tests:

@github-actions
Copy link
Contributor

Thanks for your contribution @ThibodeauJF !
When your pull-request is ready to be merged, check the box below to merge it

  • Merge! :shipit:

@github-actions
Copy link
Contributor

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

@ThibodeauJF ThibodeauJF marked this pull request as draft January 9, 2023 21:21
louis-bompart added a commit that referenced this pull request Jan 11, 2023
<!-- For Coveo Employees only. Fill this section.

CDX-764

-->

## Proposed changes

Update the snap, steal the fix from #1074
@ThibodeauJF ThibodeauJF marked this pull request as ready for review January 11, 2023 21:34
@ThibodeauJF ThibodeauJF requested a review from a team as a code owner January 11, 2023 21:34
@ThibodeauJF ThibodeauJF changed the title feat(create-atomic): migrate to Atomic V2 feat: migrate to Atomic V2 Jan 11, 2023
@louis-bompart louis-bompart merged commit 50c2f3a into master Jan 12, 2023
@louis-bompart louis-bompart deleted the CDX-1281 branch January 12, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants