feat(cli): unbundle 3rd-party CLIs (#434)

* Working™ https://coveord.atlassian.net/browse/CDX-478 * fix existing tests https://coveord.atlassian.net/browse/CDX-478 * normalize git precon+UT https://coveord.atlassian.net/browse/CDX-478 * write unit tests https://coveord.atlassian.net/browse/CDX-478 * fix bad pkg https://coveord.atlassian.net/browse/CDX-478 * ut https://coveord.atlassian.net/browse/CDX-478 * rename interfaces https://coveord.atlassian.net/browse/CDX-478 * vue: add npx https://coveord.atlassian.net/browse/CDX-478 * e2e: confirm is on stderrr https://coveord.atlassian.net/browse/CDX-478 * use error.code, remove autofix https://coveord.atlassian.net/browse/CDX-478 * better check https://coveord.atlassian.net/browse/CDX-478 * add angular-cli to test env https://coveord.atlassian.net/browse/CDX-478
coveo · Aug 19, 2021 · 377c6f5 · 377c6f5
1 parent 3eb2d06
commit 377c6f5
Show file tree

Hide file tree

Showing 28 changed files with 2,511 additions and 9,624 deletions.
diff --git a/packages/cli-e2e/__tests__/angular.specs.ts b/packages/cli-e2e/__tests__/angular.specs.ts
@@ -133,7 +133,7 @@ describe('ui:create:angular', () => {
 
     await buildTerminal
       .when(isGenericYesNoPrompt)
-      .on('stdout')
+      .on('stderr')
       .do(answerPrompt(`y${EOL}`))
       .until(buildTerminalExitPromise);
   };

diff --git a/packages/cli-e2e/entrypoints/ci.ps1 b/packages/cli-e2e/entrypoints/ci.ps1
@@ -12,6 +12,7 @@ Start-Process -FilePath $SetUserFTAPath -ArgumentList ' https ChromeHTML' -PassT
 Start-Process -FilePath $SetUserFTAPath -ArgumentList '.htm ChromeHTML' -PassThru | Wait-Process
 Start-Process -FilePath $SetUserFTAPath -ArgumentList '.html ChromeHTML' -PassThru | Wait-Process
 
+
 do {
     $ChromeTest = Test-NetConnection -ComputerName localhost -Port 9222 -InformationLevel Quiet
     Write-Output "Chrome Test $ChromeTest"
@@ -25,6 +26,8 @@ do {
 git config --global user.name "notgroot"
 git config --global user.email "[email protected]"
 
+npm install -g @angular/cli
+
 npm set registry http://localhost:4873
 yarn config set registry http://localhost:4873
 Write-Output "--mutex network" | Out-File -FilePath ~/.yarnrc -Encoding utf8 -Append

diff --git a/packages/cli-e2e/entrypoints/ci.sh b/packages/cli-e2e/entrypoints/ci.sh
@@ -21,6 +21,8 @@ git config --global user.email "[email protected]"
 
 while ! timeout 1 bash -c "echo > /dev/tcp/localhost/4873"; do sleep 10; done
 
+npm install -g @angular/cli
+
 export UI_TEMPLATE_VERSION=0.0.0
 npm set registry http://localhost:4873
 yarn config set  registry http://localhost:4873
@@ -31,7 +33,6 @@ yarn config set -- --silent true
 npm run npm:bump:template -- -- $UI_TEMPLATE_VERSION
 npm run npm:publish:template
 cd packages/cli-e2e
-
 node entrypoints/utils/wait-for-published-packages.js
 
 while ! timeout 1 bash -c "echo > /dev/tcp/localhost/9222"; do sleep 10; done

diff --git a/packages/cli-e2e/entrypoints/dockerHeadless.sh b/packages/cli-e2e/entrypoints/dockerHeadless.sh
@@ -5,12 +5,13 @@ Xvfb :1 -screen 0 1024x768x16 & sleep 1
 
 xdg-settings set default-web-browser google-chrome.desktop
 
+npm install -g @angular/cli
+
 rsync -r --exclude="node_modules" /home/notGroot/cli/* /home/notGroot/cli-copy/
 cd /home/notGroot/cli-copy
 
 npm run setup
 npm run build
-
 export UI_TEMPLATE_VERSION=0.0.0
 npm set registry http://verdaccio:4873
 yarn config set  registry http://verdaccio:4873

diff --git a/packages/cli-e2e/entrypoints/dockerX11Entry.sh b/packages/cli-e2e/entrypoints/dockerX11Entry.sh
@@ -2,6 +2,8 @@ export DISPLAY=host.docker.internal:0.0
 
 xdg-settings set default-web-browser google-chrome.desktop
 
+npm install -g @angular/cli
+
 rsync -r --exclude="node_modules" /home/notGroot/cli/* /home/notGroot/cli-copy/
 cd /home/notGroot/cli-copy