You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This makes it not possible to overwrite tag values using the builder such as when you want to start with some default values for certain tags but overwrite them later conditionally.
The simplest example:
To maintain 100% backward compatibility, we can add a setTag(key, value) method that will overwrite or create tag with key/value.
The text was updated successfully, but these errors were encountered:
xiaochuanyu
changed the title
Allow TaggedNameBuilder to overwrite tag previous value for a key
Allow TaggedNameBuilder to overwrite previous value for a key
Aug 16, 2017
Is there a particular reason why we allow duplicate key/val for tags?
I see this in the code:
metrics-datadog/metrics-datadog/src/main/java/org/coursera/metrics/datadog/TaggedName.java
Lines 96 to 100 in c497e68
This makes it not possible to overwrite tag values using the builder such as when you want to start with some default values for certain tags but overwrite them later conditionally.
The simplest example:
To maintain 100% backward compatibility, we can add a
setTag(key, value)
method that will overwrite or create tag withkey
/value
.The text was updated successfully, but these errors were encountered: