Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the datadog http client to a separate module #14

Open
amalakar opened this issue Oct 15, 2014 · 2 comments
Open

Move the datadog http client to a separate module #14

amalakar opened this issue Oct 15, 2014 · 2 comments

Comments

@amalakar
Copy link

I believe the datadog http client is valuable outside of the context of being an adapter for codahale metrics. There aren't any other http client for datadog in java/scala. I would love to use it outside the context of metrics-datadog. Thoughts?

@amalakar amalakar changed the title Move the http client to a separate module Move the datadog http client to a separate module Oct 15, 2014
@nickdella
Copy link

Yeah, I was surprised to see that there's no 'official' Java client for the Datadog APIs, so this would be a move in that direction: http://docs.datadoghq.com/libraries/ . We just went to a multi-module build thanks to #17 (thanks @tianx2!), so extracting the http client shouldn't be too difficult. I welcome your PR :)

@nhoughto
Copy link

+1 for this, we're excluding http4 and avoiding classes that import it to avoid the classpath bloat.

Also i don't think the io.dropwizard:dropwizard-metrics module is required either? i can't see where its used? That dependency brings in guava too which is whole other set of bloat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants