GPA/SD incorrectly calculated

[au5ton]

This has been kind of a long-standing issue. A good example of this is:

• This instructor's GPA is lower than it should be because some courses "don't" have a GPA: https://next.cougargrades.io/i/Han,%20Zhu
• This course "doesn't" have a GPA. This is likely because it's a pass/fail course and the "S" column will only have data in it for sections after Spring 2020: https://next.cougargrades.io/c/ECE%206111

How should this be addressed?

[au5ton]

We already have a precedent of hiding a Badge when the GPA or SD is 0. Maybe this logic could also apply to whether or not to update the GPA value for a Course or Instructor.

web/lib/data/getBadges.ts

Lines 12 to 27 in 7f51019

	...(gpa.average !== 0 ? [
	{
	key: 'gpa',
	text: formatGPAValue(gpa.average),
	color: grade2Color[getGradeForGPA(gpa.average)],
	caption: 'Grade Point Average',
	}
	] : []),
	...(gpa.average !== 0 ? [
	{
	key: 'sd',
	text: formatSDValue(gpa.standardDeviation),
	color: grade2Color[getGradeForStdDev(gpa.standardDeviation)],
	caption: 'Standard Deviation',
	}
	] : []),

Maybe include GPA if typeof GPA === 'number' && GPA > 0. Maybe this could also be addressed at a data-intake level? Should we be making sure that the GPA column in the CSV files isn't 0, but blank?

[au5ton]

Another good example to study: https://next.cougargrades.io/i/Asghar,%20Mohammad

[au5ton]

Another example:

• https://next.cougargrades.io/i/Laszka,%20Aron

[au5ton]

https://web-git-feature-random-cougargrades.vercel.app/i/Wang,%20Yuxuan

[au5ton]

This could potentially be addressed by setting AVG_GPA with null if it is 0 and there is no enrollment information. Maybe the existing algorithms can accommodate null?

[au5ton]

https://next.cougargrades.io/i/Carp,%20Robert%20A

[au5ton]

The code below is used for determining whether or now to include a section/row in a Course/Instructor's GPA:

https://github.com/cougargrades/types/blob/24ba72ed0dcbcb26fdd8a0e8dcf34f306ec03e8a/src/GradeDistributionCSVRow.ts#L202-L207

[au5ton]

Implemented in: cougargrades/publicdata@5521b25

[au5ton]

Before/After: