Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_changes with doc_ids filter does not return deleted docs #1702

Closed
snej opened this issue Apr 17, 2016 · 1 comment · Fixed by #1717
Closed

_changes with doc_ids filter does not return deleted docs #1702

snej opened this issue Apr 17, 2016 · 1 comment · Fixed by #1717
Assignees
@ajres
Labels
bug
Milestone
1.3

Comments

@snej
Copy link
Contributor

snej commented Apr 17, 2016

A request to _changes using filter=_doc_ids does not return any entries for deleted documents. This will cause problems for clients using this mode to pull a specific set of documents, because they won't find out when one of those documents is deleted.

I compared with CouchDB 1.6.1 — it does return entries for deleted documents in this case.
@snej
Copy link
Contributor Author

snej commented Apr 17, 2016

I have a new CBL/iOS unit test that reproduce this problem, but I'm going to have to comment out the bit that requests a deleted doc, in order to get the test to pass with the current Sync Gateway. The test is -[ChangeTrackerTests test_docIDs], in case you want to use it.

@zgramana zgramana added the ready label Apr 18, 2016
@zgramana zgramana added this to the 1.3 milestone Apr 18, 2016
@zgramana zgramana added the bug label Apr 18, 2016
@zgramana zgramana assigned adamcfraser and ajres and unassigned adamcfraser Apr 18, 2016
@ajres ajres added in progress and removed ready labels Apr 19, 2016
@ajres ajres mentioned this issue Apr 22, 2016
Merged
@ajres ajres added review and removed in progress labels Apr 22, 2016
@adamcfraser adamcfraser removed the review label May 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajres ajres

Labels
bug
Projects
None yet
Milestone
1.3
Development

Successfully merging a pull request may close this issue.

Returns deleted documents in one-shot replication with _doc_ids filter couchbase/sync_gateway
4 participants
@snej @zgramana @ajres @adamcfraser