-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: setup miri #74
ci: setup miri #74
Conversation
584e681
to
6f57813
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's kind of sad the tests are taking 8 minutes+ to run, but it is what it is, I guess. Hopefully they won't be too annoying, but given we don't use any unsafe code (for now), I would assume that if the normal tests pass, Miri tests will pass as well (except for the sqlite stuff, which is expected).
LGTM, but please address the comment in rust.yml
.
@m4tx, I thought about reducing the number of times it runs, maybe just to tags, considering the type of testing it is. What do you think? |
@seqre I think we can keep it for pushes/PRs for now, as long as a) we don't require them to pass to merge PRs and b) |
db
andpassword_hash
tests would not finish, investigating why can be a future endeavor