Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: setup miri #74

Merged
merged 2 commits into from
Dec 5, 2024
Merged

ci: setup miri #74

merged 2 commits into from
Dec 5, 2024

Conversation

seqre
Copy link
Member

@seqre seqre commented Nov 20, 2024

db and password_hash tests would not finish, investigating why can be a future endeavor

@seqre seqre requested review from m4tx and Iipin November 20, 2024 08:53
@seqre seqre self-assigned this Nov 20, 2024
@seqre seqre force-pushed the miri branch 3 times, most recently from 584e681 to 6f57813 Compare November 20, 2024 09:05
@seqre seqre linked an issue Nov 20, 2024 that may be closed by this pull request
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
rust 84.03% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
flareon-cli/tests/migration_generator.rs 100.00% <ø> (ø)
flareon-macros/src/dbtest.rs 92.85% <100.00%> (+0.12%) ⬆️
flareon-macros/tests/compile_tests.rs 100.00% <ø> (ø)
flareon/src/auth.rs 94.04% <ø> (ø)
flareon/src/auth/db.rs 76.66% <ø> (ø)
flareon/src/lib.rs 57.57% <ø> (ø)
flareon/src/static_files.rs 95.26% <ø> (ø)
flareon/tests/db.rs 98.66% <ø> (ø)
flareon/tests/flareon_project.rs 89.47% <ø> (ø)
flareon/tests/router.rs 93.61% <ø> (ø)

Copy link
Member

@m4tx m4tx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's kind of sad the tests are taking 8 minutes+ to run, but it is what it is, I guess. Hopefully they won't be too annoying, but given we don't use any unsafe code (for now), I would assume that if the normal tests pass, Miri tests will pass as well (except for the sqlite stuff, which is expected).

LGTM, but please address the comment in rust.yml.

@seqre
Copy link
Member Author

seqre commented Nov 20, 2024

It's kind of sad the tests are taking 8 minutes+ to run, but it is what it is, I guess. Hopefully they won't be too annoying, but given we don't use any unsafe code (for now), I would assume that if the normal tests pass, Miri tests will pass as well (except for the sqlite stuff, which is expected).

LGTM, but please address the comment in rust.yml.

@m4tx, I thought about reducing the number of times it runs, maybe just to tags, considering the type of testing it is. What do you think?

@m4tx
Copy link
Member

m4tx commented Nov 20, 2024

@seqre I think we can keep it for pushes/PRs for now, as long as a) we don't require them to pass to merge PRs and b) we don't hit the GH Actions minute limit ah I think there's no limit for public repos. Let's see how annoying they actually are!

@seqre seqre merged commit ef32d00 into master Dec 5, 2024
25 checks passed
@seqre seqre deleted the miri branch December 5, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Miri to CI
2 participants