Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing “SessionCreated” event in the event of an error at the secure endpoint #238

Closed
tinohager opened this issue Sep 24, 2024 · 2 comments

Comments

@tinohager
Copy link
Contributor

If a secure session is established on port 587 but no data is transferred and the session times out, no event is triggered. Would there be an argument against triggering the event before the UpgradeAsync?

await UpgradeAsync(handle, linkedTokenSource.Token);
linkedTokenSource.Token.ThrowIfCancellationRequested();
_smtpServer.OnSessionCreated(new SessionEventArgs(handle.SessionContext));

@cosullivan
Copy link
Owner

Yes it probably makes sense to move it.

@tinohager
Copy link
Contributor Author

I have made the changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants