Fabo/gov fixes #2167
Merged
Fabo/gov fixes #2167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedekunze
reviewed
Mar 5, 2019
Codecov Report
@@ Coverage Diff @@
## develop #2167 +/- ##
===========================================
- Coverage 95.52% 94.78% -0.75%
===========================================
Files 108 108
Lines 2278 2299 +21
Branches 115 115
===========================================
+ Hits 2176 2179 +3
- Misses 94 111 +17
- Partials 8 9 +1
|
Codecov Report
@@ Coverage Diff @@
## develop #2167 +/- ##
===========================================
+ Coverage 95.52% 95.52% +<.01%
===========================================
Files 108 108
Lines 2278 2301 +23
Branches 115 114 -1
===========================================
+ Hits 2176 2198 +22
- Misses 94 95 +1
Partials 8 8
|
jbibla
previously approved these changes
Mar 5, 2019
fedekunze
reviewed
Mar 5, 2019
Co-Authored-By: faboweb <[email protected]>
jbibla
previously approved these changes
Mar 5, 2019
|
coverage missing |
fedekunze
suggested changes
Mar 6, 2019
|
@fedekunze I think the case is:
|
That's not the case because the tx is submitted successfully |
|
hmm might have to do with the submissionError timeout. very strange. let's handle in another PR. |
fedekunze
approved these changes
Mar 6, 2019
|
ok, let's create a tracking issue for it then |
jbibla
approved these changes
Mar 6, 2019
jbibla
pushed a commit
that referenced
this pull request
Mar 7, 2019
* remove modals * tests * cha cha cha * refactored delegation modal tests * removed the "to" field on undelegation action modals * updated undelegation modal msg * lint * Fabo/gov fixes (#2167) * defensive programming * fixed * fixed sorting * optimistic updates * modals clear forms correctly * fedes changes * fixed tests * fixed more tests * changelog * coverage * Update CHANGELOG.md Co-Authored-By: faboweb <[email protected]> * added coverage * added optimistic updates for proposal creation * Jordan/2161 fixed positioning of status dot (#2172) * fixed positioning of status dot * fix for validator profile status * removed arrows from buttons, updated snaperoos * reduce margin on page validator avatar * Update CHANGELOG.md Co-Authored-By: jbibla <[email protected]> * added cosmoswallet config file * Update CHANGELOG.md * Fabo/2195 fix wrong amount on undelegation modal (#2196) * defensive programming * done * fixed tests * removed old fix * Fabo/2193 hide import (#2194) * defensive programming * hide import * changelog * tests * Fabo/1884 bring back e2e tests (#2140) * added nightwatch * changelog * direct to the correct endpoints * fixed setup and import key * reenable e2e * fixed yaml * switch workspace path * change workspace * playing with paths * paths * paths * paths * paths * cache bust * fix build script * fix build * only copy if build * try fixing glob test * attach correct workspace * correct paths * test without localstorage * serve build files for e2e tests * require build * run http-server in parallel * fix paths * updated readme * cleanup * cleanup * linted * Bump version for release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1875
Closes #1876
Description:
Thank you! 🚀
For contributor:
CHANGELOG.mdwith issue # and GitHub usernameFiles changedin the github PR explorerFor reviewer: