Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fabo/fix e2e missing button #2654

Merged
merged 7 commits into from
May 23, 2019
Merged

Fabo/fix e2e missing button #2654

merged 7 commits into from
May 23, 2019

Conversation

faboweb
Copy link
Collaborator

@faboweb faboweb commented May 23, 2019 •
edited
Loading

Also fixes a security issue by remove webpack-bundle-analyzer
Also adds screenshots on failing e2e tests

Description:

Thank you! 🚀

For contributor:

  • Added changes entries. Run yarn changelog for a guided process.
  • Reviewed Files changed in the github PR explorer
  • Attach screenshots of the UI components on the PR description (if applicable)
  • Scope of work approved for big PRs

For reviewer:

  • Manually tested the changes on the UI

@faboweb faboweb marked this pull request as ready for review May 23, 2019 17:06
@faboweb faboweb requested review from colw and jbibla as code owners May 23, 2019 17:06
colw
colw approved these changes May 23, 2019
View reviewed changes
Copy link
Contributor

@colw colw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@colw colw merged commit b810558 into develop May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colw colw colw approved these changes

@jbibla jbibla Awaiting requested review from jbibla jbibla is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@faboweb @colw