Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fabo/remove unused delegation cart #2626

Merged
merged 3 commits into from
May 20, 2019
Merged

Fabo/remove unused delegation cart #2626

merged 3 commits into from
May 20, 2019

Conversation

faboweb
Copy link
Collaborator

@faboweb faboweb commented May 18, 2019

Closes #ISSUE

Description:

Thank you! 🚀

For contributor:

  • Added changes entries. Run yarn changelog for a guided process.
  • Reviewed Files changed in the github PR explorer
  • Attach screenshots of the UI components on the PR description (if applicable)
  • Scope of work approved for big PRs

For reviewer:

  • Manually tested the changes on the UI

@faboweb faboweb requested a review from jbibla as a code owner May 18, 2019 16:38
@colw
Copy link
Contributor

colw commented May 20, 2019

Code deletion, excellent!

@colw colw self-assigned this May 20, 2019
@colw colw self-requested a review May 20, 2019 11:02
@colw colw removed their assignment May 20, 2019
colw
colw approved these changes May 20, 2019
View reviewed changes
Copy link
Contributor

@colw colw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@colw colw merged commit aa999da into develop May 20, 2019
This was referenced May 20, 2019
Closed
Merged
@colw colw deleted the fabo/remove-unused-delegations-cart branch September 18, 2019 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colw colw colw approved these changes

@jbibla jbibla Awaiting requested review from jbibla jbibla is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@faboweb @colw