Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add white-space: normal to circle—default class #2617

Merged
merged 2 commits into from
May 18, 2019

Conversation

migueog
Copy link
Contributor

@migueog migueog commented May 17, 2019

Closes #2615

Description:

The fix for this issue is to add white-space: normal to override an inherited style.

Seems that the other modals were not affected because their parent isn't TmPageHeader.

https://vue-loader.vuejs.org/guide/scoped-css.html#child-component-root-elements

Thank you! 🚀


For contributor:

  • Added changes entries. Run yarn changelog for a guided process.
  • Reviewed Files changed in the github PR explorer
  • Attach screenshots of the UI components on the PR description (if applicable)
  • Scope of work approved for big PRs

For reviewer:

  • Manually tested the changes on the UI

@migueog migueog requested a review from jbibla May 17, 2019 18:15
@migueog migueog requested a review from faboweb as a code owner May 17, 2019 18:15
@faboweb
Copy link
Collaborator

faboweb commented May 18, 2019

This sounds like an issue with TmPageHeader. Are the styles there scoped? In theory styles should not bleed into child components. Maybe you found a bug there.
Also a comparison of the change via screenshots would be nice.

@faboweb faboweb closed this May 18, 2019
@faboweb faboweb deleted the miguel/2615-step-component-withdraw-style-fix branch May 18, 2019 16:21
@faboweb faboweb restored the miguel/2615-step-component-withdraw-style-fix branch May 18, 2019 16:21
@faboweb faboweb reopened this May 18, 2019
@faboweb faboweb merged commit c271f05 into develop May 18, 2019
@faboweb
Copy link
Collaborator

faboweb commented May 18, 2019

Note: It's nice to say what this is fixing in comparison to saying what it implements. This way I can quicker access the change.

@faboweb faboweb deleted the miguel/2615-step-component-withdraw-style-fix branch May 18, 2019 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Step component breaks in withdraw modal
2 participants