Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fabo/ removed keybase calls and validatorset calls #2551

Merged
merged 2 commits into from
May 7, 2019
Merged

Fabo/ removed keybase calls and validatorset calls #2551

merged 2 commits into from
May 7, 2019

Conversation

faboweb
Copy link
Collaborator

@faboweb faboweb commented May 7, 2019

Closes #ISSUE

Description:

Thank you! 🚀

For contributor:

  • Added changes entries. Run yarn changelog for a guided process.
  • Reviewed Files changed in the github PR explorer
  • Attach screenshots of the UI components on the PR description (if applicable)
  • Scope of work approved for big PRs

For reviewer:

  • Manually tested the changes on the UI

@faboweb faboweb requested review from fedekunze and jbibla as code owners May 7, 2019 16:12
jbibla
jbibla approved these changes May 7, 2019
View reviewed changes
Copy link
Collaborator

@jbibla jbibla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me.

@jbibla jbibla merged commit f7b0559 into develop May 7, 2019
@jbibla jbibla deleted the fabo/remove-validatorset-call branch May 7, 2019 19:44
@faboweb faboweb mentioned this pull request May 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbibla jbibla jbibla approved these changes

@fedekunze fedekunze Awaiting requested review from fedekunze

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@faboweb @jbibla