-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable withdrawal when user doesn't have any delegations #2378
Comments
how can a user do a withdrawal of zero? doesn't that mean we're not validating the form? |
there's no "form" we only display the total rewards as the message doesn't contain any amount field |
ah ok. so we should just show a message on the action modal when rewards = 0 |
When delegations.length = 0 |
ohhhhhhh. yeah. but also when rewards = 0 i guess. |
You get rewards on every block so I wouldn’t bother handling that case |
ah, i see what you're saying. i suppose we agree on what the outcome should be. i'll leave the implementation to you! |
Describe the bug
Attempting to do a withdrawal without delegations renders the following error on the modal:
Withdrawal failed: JSON Missing msgs.
To Reproduce
Expected behavior
Show a message that user needs to delegate to be able to withdraw.
The text was updated successfully, but these errors were encountered: