chore: rm mbt, trace tests from CI; fix dependabot #2000
Conversation
WalkthroughWalkthroughThe changes mainly involve removing jobs related to testing from the GitHub Actions workflow file ( Changes
Sequence Diagram(s)No sequence diagram is necessary as the changes are primarily removals and formatting adjustments that do not impact the control flow or introduce new features. Recent review detailsConfiguration used: .coderabbit.yml Files selected for processing (1)
Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
MSalopek
force-pushed
the
ph/remove-mbt-from-ci
branch
from
62fb9e2
to
22b8855
Compare
MSalopek
changed the title
MSalopek
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
.github/workflows/test.yml (1)
Line range hint
51-71: Dependency ontest-mbtneeds removal.The
repo-analysisjob still liststest-mbtas a dependency. This should be removed as part of the MBT deprecation.- needs: [tests, test-integration, test-mbt] + needs: [tests, test-integration]
MSalopek
changed the title
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (3)
.github/workflows/test.yml (3)
Line range hint
104-104: Potential issue: Orphan job dependency.The
repo-analysisjob liststest-mbtin itsneedsattribute. Sincetest-mbtis being removed, this reference should also be updated to prevent workflow errors.- needs: [tests, test-integration, test-mbt] + needs: [tests, test-integration]
Line range hint
133-142: Check for potential unused artifacts.The
repo-analysisjob attempts to download an artifact named"${{ github.sha }}-mbt-coverage". With the removal of thetest-mbtjob, this artifact will no longer be produced, and this step will always fail, even withcontinue-on-errorset to true. Consider removing or modifying this step.- - uses: actions/download-artifact@v4 - if: env.GIT_DIFF - with: - name: "${{ github.sha }}-mbt-coverage" - continue-on-error: true
Remove the
model-analysisjob from the workflow.The
model-analysisjob is part of the MBT framework, as it includes steps that referencetests/mbt/model/**.qntand involves verifying models. Since the MBT framework is being removed, this job should be removed as well.
- File:
.github/workflows/test.yml- Lines: 174-187
Analysis chain
Line range hint
174-187: Review the model-analysis job.This job seems to be related to model testing and might be part of the MBT framework. Verify if this job should also be removed or modified in the context of removing MBT from the workflow.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check if the model-analysis job is related to the MBT framework and should be removed. # Test: Search for mentions of `model-analysis` in related documentation or code comments. rg --type markdown -A 5 "model-analysis"Length of output: 40
Script:
#!/bin/bash # Description: Search for the model-analysis job in the YAML workflow files to understand its context. # Test: Search for mentions of `model-analysis` in the .github/workflows directory. rg "model-analysis" .github/workflows/*.yml -A 10Length of output: 1061
Script:
#!/bin/bash # Description: Search for the complete model-analysis job definition in the .github/workflows/test.yml file. # Test: Extract the full job definition for `model-analysis` to understand its context. rg "model-analysis:" .github/workflows/test.yml -A 50Length of output: 648
* Remove MBT from pipeline * chore: disable trace tests * cleanup dependabot * cleanup test --------- Co-authored-by: MSalopek <[email protected]> (cherry picked from commit eb93342) # Conflicts: # .github/dependabot.yml # .github/workflows/test.yml
…2039) * Remove MBT from pipeline * chore: rm mbt, trace tests from CI; fix dependabot (#2000) * Remove MBT from pipeline * chore: disable trace tests * cleanup dependabot * cleanup test --------- Co-authored-by: MSalopek <[email protected]> (cherry picked from commit eb93342) # Conflicts: # .github/dependabot.yml # .github/workflows/test.yml * Fix merge --------- Co-authored-by: Philip Offtermatt <[email protected]> Co-authored-by: Philip Offtermatt <[email protected]>
* Remove MBT from pipeline * chore: disable trace tests * cleanup dependabot * cleanup test --------- Co-authored-by: MSalopek <[email protected]>
Description
Closes: #N/A
MBT is currently deprecated, and the tests fail regularly starting with the upgrade to Cosmos sdk v50.
Trace tests are doing the same work as e2e tests, so we are disabling them for the time being.
Dependabot configuration was broken a couple weeks ago.
For more context, see #1987 for a brief overview of the future plans for randomized testing.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
Summary by CodeRabbit
test-mbtandtest-tracejobs from the CI workflow..github/dependabot.ymlfile for better readability.