-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the CI system work on the 47 upgrade branch #956
Comments
Have you tried opening a draft PR for the feature branch? Also does |
@smarshall-spitzbart make test will not allow us (Notional) to collaborate with you (Informal) on a shared source of truth. The CI system will do that, however. The issue is that we could go back and forth literally for days discussing the results of each of our "make test" and then eventually learn that the issue was with your or my local environment. The CI system will run in the same way every time. |
@smarshall-spitzbart -- there's some more information available to you here too: |
upgrade-ics-sdk47-ibc7
Can handle this but it'll need to be sometime next week. It's not a good idea to ask contributors to contribute to branches that don't have CI when CI forms a very key part of the verification of pull requests as functional or not.
Such practices slow the pace of critical work and introduce a margin for error that can cause bugs.
The text was updated successfully, but these errors were encountered: