Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mismatching comment/code in unjailValidator #1173

Closed
5 tasks
p-offtermatt opened this issue Aug 1, 2023 · 0 comments · Fixed by #1174
Closed
5 tasks

Mismatching comment/code in unjailValidator #1173

p-offtermatt opened this issue Aug 1, 2023 · 0 comments · Fixed by #1174
Assignees
@p-offtermatt
Labels
scope: docs Improvements or additions to documentation type: bug Issues that need priority attention -- something isn't working

Comments

@p-offtermatt
Copy link
Contributor

Summary of Bug

In the e2e tests, the unjailValidatorAction has a misleading comment
here -
the comment says to wait a block, but this waits the downtime_jail_duration (60 seconds), not a block.

Version

7484dbc

Steps to Reproduce

N/A

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
  • Is a spike necessary to map out how the issue should be approached?
@p-offtermatt p-offtermatt added type: bug Issues that need priority attention -- something isn't working scope: docs Improvements or additions to documentation labels Aug 1, 2023
@p-offtermatt p-offtermatt self-assigned this Aug 1, 2023
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Cosmos Hub Aug 1, 2023
@p-offtermatt p-offtermatt moved this from 🩹 Triage to 🏗 In progress in Cosmos Hub Aug 1, 2023
@p-offtermatt p-offtermatt moved this from 🏗 In progress to 👀 In review in Cosmos Hub Aug 1, 2023
@p-offtermatt p-offtermatt mentioned this issue Aug 1, 2023
Merged
8 tasks
@p-offtermatt p-offtermatt linked a pull request Aug 1, 2023 that will close this issue
test: Fix mismatching code/comment and use WaitTime instead of sleep #1174
Merged
8 tasks
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Cosmos Hub Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@p-offtermatt p-offtermatt

Labels
scope: docs Improvements or additions to documentation type: bug Issues that need priority attention -- something isn't working
Projects
Cosmos Hub
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: Fix mismatching code/comment and use WaitTime instead of sleep cosmos/interchain-security
1 participant
@p-offtermatt