From e51fd3ef10a9053a0229088bdc04631a418a7b64 Mon Sep 17 00:00:00 2001 From: Carlos Rodriguez Date: Wed, 19 Oct 2022 10:56:23 +0200 Subject: [PATCH 1/3] update comment --- spec/core/ics-004-channel-and-packet-semantics/README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/spec/core/ics-004-channel-and-packet-semantics/README.md b/spec/core/ics-004-channel-and-packet-semantics/README.md index 7d71e9ae2..fb894058c 100644 --- a/spec/core/ics-004-channel-and-packet-semantics/README.md +++ b/spec/core/ics-004-channel-and-packet-semantics/README.md @@ -533,7 +533,7 @@ Calling modules MUST execute application logic atomically in conjunction with ca The IBC handler performs the following steps in order: -- Checks that the channel & connection are open to send packets +- Checks that the channel in not closed to send packets - Checks that the calling module owns the sending port (see [ICS 5](../ics-005-port-allocation)) - Checks that the timeout height specified has not already passed on the destination chain - Increments the send sequence counter associated with the channel @@ -551,7 +551,7 @@ function sendPacket( data: bytes) { channel = provableStore.get(channelPath(sourcePort, sourceChannel)) - // check that the channel & connection are open to send packets; + // check that the channel is not closed to send packets; // note: optimistic sends are permitted once the handshake has started abortTransactionUnless(channel !== null) abortTransactionUnless(channel.state !== CLOSED) From 726b145484627c47718c1f208da0fb5bb4d63c65 Mon Sep 17 00:00:00 2001 From: Carlos Rodriguez Date: Wed, 19 Oct 2022 10:57:44 +0200 Subject: [PATCH 2/3] typo --- spec/core/ics-004-channel-and-packet-semantics/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spec/core/ics-004-channel-and-packet-semantics/README.md b/spec/core/ics-004-channel-and-packet-semantics/README.md index fb894058c..6a645210a 100644 --- a/spec/core/ics-004-channel-and-packet-semantics/README.md +++ b/spec/core/ics-004-channel-and-packet-semantics/README.md @@ -533,7 +533,7 @@ Calling modules MUST execute application logic atomically in conjunction with ca The IBC handler performs the following steps in order: -- Checks that the channel in not closed to send packets +- Checks that the channel is not closed to send packets - Checks that the calling module owns the sending port (see [ICS 5](../ics-005-port-allocation)) - Checks that the timeout height specified has not already passed on the destination chain - Increments the send sequence counter associated with the channel From 355deec51972bc4320c00054953246f2d6380bc2 Mon Sep 17 00:00:00 2001 From: Carlos Rodriguez Date: Tue, 15 Nov 2022 09:50:42 +0100 Subject: [PATCH 3/3] remove comment --- spec/core/ics-004-channel-and-packet-semantics/README.md | 1 - 1 file changed, 1 deletion(-) diff --git a/spec/core/ics-004-channel-and-packet-semantics/README.md b/spec/core/ics-004-channel-and-packet-semantics/README.md index 6a645210a..0e89625b7 100644 --- a/spec/core/ics-004-channel-and-packet-semantics/README.md +++ b/spec/core/ics-004-channel-and-packet-semantics/README.md @@ -552,7 +552,6 @@ function sendPacket( channel = provableStore.get(channelPath(sourcePort, sourceChannel)) // check that the channel is not closed to send packets; - // note: optimistic sends are permitted once the handshake has started abortTransactionUnless(channel !== null) abortTransactionUnless(channel.state !== CLOSED) connection = provableStore.get(connectionPath(channel.connectionHops[0]))