Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICS4: Prefix Upgrade Keys #807

Merged
merged 3 commits into from
Aug 1, 2022
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,3 +38,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
# Changelog

## [Unreleased]

### Improvements

- [\#807](https://github.com/cosmos/ibc/pull/807) Upgrade keys will now prefix the channel path to align with the rest of ICS4 keys
8 changes: 4 additions & 4 deletions spec/core/ics-004-channel-and-packet-semantics/UPGRADES.md
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ The upgrade sequence path is a public path that stores the current sequence of t

```typescript
function channelUpgradeSequencePath(portIdentifier: Identifier, channelIdentifier: Identifier) Path {
return "channelUpgrades/ports/{portIdentifier}/channels/{channelIdentifier}/upgradeSequence"
return "channelUpgrades/upgradeSequence/ports/{portIdentifier}/channels/{channelIdentifier}"
}
```

Expand Down Expand Up @@ -129,7 +129,7 @@ The chain must store the previous channel end so that it may restore it if the u

```typescript
function channelRestorePath(portIdentifier: Identifier, channelIdentifier: Identifier): Path {
return "channelUpgrades/ports/{portIdentifier}/channels/{channelIdentifier}/restore"
return "channelUpgrades/restore/ports/{portIdentifier}/channels/{channelIdentifier}"
}
```

Expand All @@ -139,7 +139,7 @@ The upgrade error path is a public path that can signal an error of the upgrade

```typescript
function channelUpgradeErrorPath(portIdentifier: Identifier, channelIdentifier: Identifier): Path {
return "channelUpgrades/ports/{portIdentifier}/channels/{channelIdentifier}/upgradeError"
return "channelUpgrades/upgradeError/ports/{portIdentifier}/channels/{channelIdentifier}"
}
```

Expand Down Expand Up @@ -182,7 +182,7 @@ The upgrade timeout path is a public path set by the upgrade initiator to determ

```typescript
function channelUpgradeTimeoutPath(portIdentifier: Identifier, channelIdentifier: Identifier) Path {
return "channelUpgrades/ports/{portIdentifier}/channels/{channelIdentifier}/upgradeTimeout"
return "channelUpgrades/upgradeTimeout/ports/{portIdentifier}/channels/{channelIdentifier}"
}
```

Expand Down