We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Currently if there are crossing hellos of incompatible upgrades with unequal sequences.
The TRY will be explicitly rejected on both sides due to an earlier compatibility check before the sequencing logic can write an error receipt.
This then will require an explicit reset by one of the parties to continue the handshake.
One alternative approach could be to instead do the sequencing check first and error out the lower sequence incompatible upgrade.
The text was updated successfully, but these errors were encountered:
Thanks for this catch! The alternative approach LGTM!
Sorry, something went wrong.
Successfully merging a pull request may close this issue.
Currently if there are crossing hellos of incompatible upgrades with unequal sequences.
The TRY will be explicitly rejected on both sides due to an earlier compatibility check before the sequencing logic can write an error receipt.
This then will require an explicit reset by one of the parties to continue the handshake.
One alternative approach could be to instead do the sequencing check first and error out the lower sequence incompatible upgrade.
The text was updated successfully, but these errors were encountered: