Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICS 04 (upgrades): Use counterparty connection hops when verifying channel state in UpgradeOpen. #1004

Closed
DimitrisJim opened this issue Jul 13, 2023 · 0 comments · Fixed by #1008
Closed

ICS 04 (upgrades): Use counterparty connection hops when verifying channel state in UpgradeOpen. #1004

DimitrisJim opened this issue Jul 13, 2023 · 0 comments · Fixed by #1008
Assignees
@crodriguezvega
Labels
bug tao Transport, authentication, & ordering layer.

Comments

@DimitrisJim
Copy link
Contributor

Specifically, when the counterparty is in OPEN, we should be using the counterparty connection hops based on the upgraded connection end. Relevant PR cosmos/ibc-go#4074

Might be addressed in spec via #999 if we decide to store the full counterparty upgrade.
@DimitrisJim DimitrisJim mentioned this issue Jul 13, 2023
Merged
9 tasks
@crodriguezvega crodriguezvega added tao Transport, authentication, & ordering layer. bug labels Jul 14, 2023
@crodriguezvega crodriguezvega changed the title Use counterparty connection hops when verifying channel state in UpgradeOpen. ICS 04 (upgrades): Use counterparty connection hops when verifying channel state in UpgradeOpen. Jul 14, 2023
@crodriguezvega crodriguezvega mentioned this issue Jul 27, 2023
Merged
@crodriguezvega crodriguezvega self-assigned this Jul 30, 2023
@crodriguezvega crodriguezvega linked a pull request Jul 30, 2023 that will close this issue
ICS 04 (upgrades): fix counterparty connection hops in chanUpgradeOpen #1008
Merged
@crodriguezvega crodriguezvega mentioned this issue Jul 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crodriguezvega crodriguezvega

Labels
bug tao Transport, authentication, & ordering layer.
Projects
IBC-GO Eureka
Status: Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ICS 04 (upgrades): fix counterparty connection hops in chanUpgradeOpen cosmos/ibc
2 participants
@crodriguezvega @DimitrisJim