-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement ClientState::status()
#774
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #774 +/- ##
==========================================
+ Coverage 67.90% 71.49% +3.59%
==========================================
Files 124 124
Lines 14806 14960 +154
==========================================
+ Hits 10054 10696 +642
+ Misses 4752 4264 -488
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few suggestions. Otherwise LGTM. Thanks 🙏
@@ -75,7 +75,7 @@ scale-info = { version = "2.1.2", default-features = false, features = ["derive" | |||
borsh = {version = "0.9.0", default-features = false, optional = true } | |||
parking_lot = { version = "0.12.1", default-features = false, optional = true } | |||
|
|||
ibc-derive = "0.2.0" | |||
ibc-derive = { version ="0.2.0", path = "../ibc-derive" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: I had to reincorporate the path
because otherwise whenever we make changes to ibc-derive
, ibc
doesn't see the changes, and it fails to compile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Therefore, good to add a [ibc-drive]
tag for unclog. Like how this handled e.g. in tendermint-rs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was thinking of adding this to the contributing.md
. I see we already have it here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a unclog
update and we are good. Thanks 🌷
Updated changelog; is this what you had in mind? Basically now we have only 1 entry that points to |
Yup, this works. |
* Status enum * implement status API * replace most confirm_not_frozen * validate_self_client no longer uses confirm_not_frozen * remove confirm_not_frozen * clippy * fix test * remove expired() * changelog * Remove `Status::Unknown` * don't consider the client expired if consensus state is in the future * Status methods * remove redundant check * Remove error variant * update changelog
Closes: #536