Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IbcEventType #624

Merged
merged 6 commits into from
Apr 20, 2023
Merged

Remove IbcEventType #624

merged 6 commits into from
Apr 20, 2023

Conversation

plafer
Copy link
Contributor

@plafer plafer commented Apr 14, 2023

Closes: #623


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@plafer plafer requested a review from Farhad-Shabani April 14, 2023 18:27
@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Patch coverage: 34.63% and project coverage change: -0.23 ⚠️

Comparison is base (014fec6) 73.19% compared to head (4f5218f) 72.97%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #624      +/-   ##
==========================================
- Coverage   73.19%   72.97%   -0.23%     
==========================================
  Files         125      125              
  Lines       15660    15647      -13     
==========================================
- Hits        11463    11418      -45     
- Misses       4197     4229      +32     
Impacted Files Coverage Δ
crates/ibc/src/core/handler.rs 74.64% <ø> (ø)
crates/ibc/src/events.rs 18.88% <4.65%> (-13.65%) ⬇️
crates/ibc/src/core/ics04_channel/events.rs 44.92% <27.58%> (-2.00%) ⬇️
crates/ibc/src/core/ics02_client/events.rs 70.90% <48.00%> (-3.14%) ⬇️
crates/ibc/src/core/context/acknowledgement.rs 97.44% <50.00%> (ø)
crates/ibc/src/core/context/chan_close_confirm.rs 96.39% <50.00%> (ø)
crates/ibc/src/core/context/chan_close_init.rs 96.55% <50.00%> (ø)
crates/ibc/src/core/context/chan_open_ack.rs 96.85% <50.00%> (ø)
crates/ibc/src/core/context/chan_open_confirm.rs 96.92% <50.00%> (ø)
crates/ibc/src/core/context/chan_open_init.rs 96.74% <50.00%> (ø)
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@Farhad-Shabani Farhad-Shabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🙏

@plafer plafer merged commit 8ed4655 into main Apr 20, 2023
@plafer plafer deleted the plafer/623-remove-ibceventtype branch April 20, 2023 13:53
Farhad-Shabani pushed a commit that referenced this pull request Sep 9, 2024
* remove `FromStr`

* Create MessageEvent

* replace todo

* remove IbcEventType

* rename IbcEvent::AppModule

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix IbcEventType
2 participants