Packet data must not be assumed to be valid UTF-8 #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romac
changed the title
romac
reviewed
Oct 27, 2022
Signed-off-by: Romain Ruetschi <[email protected]>
romac
approved these changes
Oct 27, 2022
plafer
added a commit
that referenced
this pull request
Oct 27, 2022
* Make `ClientType` allow any string value (#189) * ClientType now wraps a str * Make ClientType accept any string * doctest * changelog * use client_type() fn instead of constant * use client_type() for mock * release v0.21.0 (#192) * release v0.21.0 * version bumped to 0.21.0 * contributing edit * Update .changelog/v0.21.0/summary.md Co-authored-by: Romain Ruetschi <[email protected]> Signed-off-by: Philippe Laferrière <[email protected]> * Update CHANGELOG.md Co-authored-by: Romain Ruetschi <[email protected]> Signed-off-by: Philippe Laferrière <[email protected]> Signed-off-by: Philippe Laferrière <[email protected]> Co-authored-by: Romain Ruetschi <[email protected]> * Packet data must not be assumed to be valid UTF-8 (#200) * Add failing test * fix the bug * changelog * fmt * Reword a couple messages Signed-off-by: Romain Ruetschi <[email protected]> Co-authored-by: Romain Ruetschi <[email protected]> * Release v0.21.1 (#202) * release v0.21.1 * bump to version 0.21.1 Signed-off-by: Philippe Laferrière <[email protected]> Signed-off-by: Romain Ruetschi <[email protected]> Co-authored-by: Romain Ruetschi <[email protected]>
plafer
added a commit
that referenced
this pull request
Oct 27, 2022
* Make `ClientType` allow any string value (#189) * ClientType now wraps a str * Make ClientType accept any string * doctest * changelog * use client_type() fn instead of constant * use client_type() for mock * release v0.21.0 (#192) * release v0.21.0 * version bumped to 0.21.0 * contributing edit * Update .changelog/v0.21.0/summary.md Co-authored-by: Romain Ruetschi <[email protected]> Signed-off-by: Philippe Laferrière <[email protected]> * Update CHANGELOG.md Co-authored-by: Romain Ruetschi <[email protected]> Signed-off-by: Philippe Laferrière <[email protected]> Signed-off-by: Philippe Laferrière <[email protected]> Co-authored-by: Romain Ruetschi <[email protected]> * Packet data must not be assumed to be valid UTF-8 (#200) * Add failing test * fix the bug * changelog * fmt * Reword a couple messages Signed-off-by: Romain Ruetschi <[email protected]> Co-authored-by: Romain Ruetschi <[email protected]> * Release v0.21.1 (#202) * release v0.21.1 * bump to version 0.21.1 Signed-off-by: Philippe Laferrière <[email protected]> Signed-off-by: Romain Ruetschi <[email protected]> Co-authored-by: Romain Ruetschi <[email protected]>
plafer
added a commit
that referenced
this pull request
Nov 3, 2022
* few channel attributes * Refactor Channel's `OpenInit` * Create channel_events() and remove event emission from all channel handlers * channel OpenTry event cleaned up * OpenAck cleaned up * OpenConfirm cleaned up * cleanup chan_close_init * cleanup CloseConfirm event and remove Attributes * Remove unused trait * fix compilation + clippy * fix tests * finish implementing channel_events() * channel_dispatch now discards events * clean up generated logs * chan_open_init_event test * chan_open_try_event test * chan_open_ack_event test * test_chan_open_confirm_event test * chan_close_init event test * chan_close_confirm_event test * clippy * DataAttribute struct * DataHexAttribute * TimeoutHeightAttribute * TimeoutTimestampAttribute * SequenceAttribute * ChannelOrderingAttribute * Merge v0.21.1 (#203) * Make `ClientType` allow any string value (#189) * ClientType now wraps a str * Make ClientType accept any string * doctest * changelog * use client_type() fn instead of constant * use client_type() for mock * release v0.21.0 (#192) * release v0.21.0 * version bumped to 0.21.0 * contributing edit * Update .changelog/v0.21.0/summary.md Co-authored-by: Romain Ruetschi <[email protected]> Signed-off-by: Philippe Laferrière <[email protected]> * Update CHANGELOG.md Co-authored-by: Romain Ruetschi <[email protected]> Signed-off-by: Philippe Laferrière <[email protected]> Signed-off-by: Philippe Laferrière <[email protected]> Co-authored-by: Romain Ruetschi <[email protected]> * Packet data must not be assumed to be valid UTF-8 (#200) * Add failing test * fix the bug * changelog * fmt * Reword a couple messages Signed-off-by: Romain Ruetschi <[email protected]> Co-authored-by: Romain Ruetschi <[email protected]> * Release v0.21.1 (#202) * release v0.21.1 * bump to version 0.21.1 Signed-off-by: Philippe Laferrière <[email protected]> Signed-off-by: Romain Ruetschi <[email protected]> Co-authored-by: Romain Ruetschi <[email protected]> * merge DataAttribute and DataHexAttribute * chan_open_init event compatible * recv_packet compatible * fix previous events * WriteAcknowledgement compatible * Acknowledgement event compatible * packet Timeout event compatible * timeout_on_close handler event emission compatible * Remove stale code * create ChannelClosed event * from -> into * rename PacketMsg timeout variants * update comment * ChannelClosed event in timeout handler * timeout on close * changelog * move channel attributes to a submodule * move packet attributes to submodule * Update crates/ibc/src/core/ics04_channel/events.rs Co-authored-by: Shoaib Ahmed <[email protected]> Signed-off-by: Philippe Laferrière <[email protected]> * Update crates/ibc/src/core/ics04_channel/events.rs Co-authored-by: Shoaib Ahmed <[email protected]> Signed-off-by: Philippe Laferrière <[email protected]> * asref counterparty channel id * timeoutPacket event fix * write_acknowledgement fix * acknowledge packet fix * write ack actual fix * fix counterparty attributes * add clarifying comment * Update crates/ibc/src/core/ics04_channel/events.rs Co-authored-by: Shoaib Ahmed <[email protected]> Signed-off-by: Philippe Laferrière <[email protected]> * Update crates/ibc/src/core/ics04_channel/events.rs Co-authored-by: Shoaib Ahmed <[email protected]> Signed-off-by: Philippe Laferrière <[email protected]> * clippy Signed-off-by: Philippe Laferrière <[email protected]> Signed-off-by: Romain Ruetschi <[email protected]> Co-authored-by: Romain Ruetschi <[email protected]> Co-authored-by: Shoaib Ahmed <[email protected]>
Farhad-Shabani
pushed a commit
that referenced
this pull request
Sep 9, 2024
* Make `ClientType` allow any string value (#189) * ClientType now wraps a str * Make ClientType accept any string * doctest * changelog * use client_type() fn instead of constant * use client_type() for mock * release v0.21.0 (#192) * release v0.21.0 * version bumped to 0.21.0 * contributing edit * Update .changelog/v0.21.0/summary.md Co-authored-by: Romain Ruetschi <[email protected]> Signed-off-by: Philippe Laferrière <[email protected]> * Update CHANGELOG.md Co-authored-by: Romain Ruetschi <[email protected]> Signed-off-by: Philippe Laferrière <[email protected]> Signed-off-by: Philippe Laferrière <[email protected]> Co-authored-by: Romain Ruetschi <[email protected]> * Packet data must not be assumed to be valid UTF-8 (#200) * Add failing test * fix the bug * changelog * fmt * Reword a couple messages Signed-off-by: Romain Ruetschi <[email protected]> Co-authored-by: Romain Ruetschi <[email protected]> * Release v0.21.1 (#202) * release v0.21.1 * bump to version 0.21.1 Signed-off-by: Philippe Laferrière <[email protected]> Signed-off-by: Romain Ruetschi <[email protected]> Co-authored-by: Romain Ruetschi <[email protected]>
Farhad-Shabani
pushed a commit
that referenced
this pull request
Sep 9, 2024
* few channel attributes * Refactor Channel's `OpenInit` * Create channel_events() and remove event emission from all channel handlers * channel OpenTry event cleaned up * OpenAck cleaned up * OpenConfirm cleaned up * cleanup chan_close_init * cleanup CloseConfirm event and remove Attributes * Remove unused trait * fix compilation + clippy * fix tests * finish implementing channel_events() * channel_dispatch now discards events * clean up generated logs * chan_open_init_event test * chan_open_try_event test * chan_open_ack_event test * test_chan_open_confirm_event test * chan_close_init event test * chan_close_confirm_event test * clippy * DataAttribute struct * DataHexAttribute * TimeoutHeightAttribute * TimeoutTimestampAttribute * SequenceAttribute * ChannelOrderingAttribute * Merge v0.21.1 (#203) * Make `ClientType` allow any string value (#189) * ClientType now wraps a str * Make ClientType accept any string * doctest * changelog * use client_type() fn instead of constant * use client_type() for mock * release v0.21.0 (#192) * release v0.21.0 * version bumped to 0.21.0 * contributing edit * Update .changelog/v0.21.0/summary.md Co-authored-by: Romain Ruetschi <[email protected]> Signed-off-by: Philippe Laferrière <[email protected]> * Update CHANGELOG.md Co-authored-by: Romain Ruetschi <[email protected]> Signed-off-by: Philippe Laferrière <[email protected]> Signed-off-by: Philippe Laferrière <[email protected]> Co-authored-by: Romain Ruetschi <[email protected]> * Packet data must not be assumed to be valid UTF-8 (#200) * Add failing test * fix the bug * changelog * fmt * Reword a couple messages Signed-off-by: Romain Ruetschi <[email protected]> Co-authored-by: Romain Ruetschi <[email protected]> * Release v0.21.1 (#202) * release v0.21.1 * bump to version 0.21.1 Signed-off-by: Philippe Laferrière <[email protected]> Signed-off-by: Romain Ruetschi <[email protected]> Co-authored-by: Romain Ruetschi <[email protected]> * merge DataAttribute and DataHexAttribute * chan_open_init event compatible * recv_packet compatible * fix previous events * WriteAcknowledgement compatible * Acknowledgement event compatible * packet Timeout event compatible * timeout_on_close handler event emission compatible * Remove stale code * create ChannelClosed event * from -> into * rename PacketMsg timeout variants * update comment * ChannelClosed event in timeout handler * timeout on close * changelog * move channel attributes to a submodule * move packet attributes to submodule * Update crates/ibc/src/core/ics04_channel/events.rs Co-authored-by: Shoaib Ahmed <[email protected]> Signed-off-by: Philippe Laferrière <[email protected]> * Update crates/ibc/src/core/ics04_channel/events.rs Co-authored-by: Shoaib Ahmed <[email protected]> Signed-off-by: Philippe Laferrière <[email protected]> * asref counterparty channel id * timeoutPacket event fix * write_acknowledgement fix * acknowledge packet fix * write ack actual fix * fix counterparty attributes * add clarifying comment * Update crates/ibc/src/core/ics04_channel/events.rs Co-authored-by: Shoaib Ahmed <[email protected]> Signed-off-by: Philippe Laferrière <[email protected]> * Update crates/ibc/src/core/ics04_channel/events.rs Co-authored-by: Shoaib Ahmed <[email protected]> Signed-off-by: Philippe Laferrière <[email protected]> * clippy Signed-off-by: Philippe Laferrière <[email protected]> Signed-off-by: Romain Ruetschi <[email protected]> Co-authored-by: Romain Ruetschi <[email protected]> Co-authored-by: Shoaib Ahmed <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #199
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.