Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imp: relax timeout check in MsgTransfer conversions #1363

Merged

Conversation

Farhad-Shabani
Copy link
Member

Closes: #1362


PR author checklist:

  • Added changelog entry, using unclog.
  • Linked to GitHub issue.
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@Farhad-Shabani Farhad-Shabani added this to the 0.56.0 milestone Oct 21, 2024
@Farhad-Shabani Farhad-Shabani requested a review from rnbguy October 21, 2024 19:15
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.88%. Comparing base (cdd4625) to head (12658cd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1363      +/-   ##
==========================================
+ Coverage   66.84%   66.88%   +0.04%     
==========================================
  Files         225      225              
  Lines       22631    22617      -14     
==========================================
  Hits        15127    15127              
+ Misses       7504     7490      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@rnbguy rnbguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch ! 👍

@Farhad-Shabani Farhad-Shabani added this pull request to the merge queue Oct 22, 2024
Merged via the queue into main with commit 5ae8860 Oct 22, 2024
14 checks passed
@Farhad-Shabani Farhad-Shabani deleted the farhad/relax-timeout-check-in-MsgTransfer-conversions branch October 22, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redundant timeout check during MsgTransfer proto to domain conversions
2 participants