Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up generic String variants in error types #1347

Merged
merged 21 commits into from
Sep 20, 2024
Merged

Clean up generic String variants in error types #1347

merged 21 commits into from
Sep 20, 2024

Commits on Sep 18, 2024

  1. Clean up most instances of ClientError::Other

    @seanchen1991
    seanchen1991 committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    4ef2890 View commit details
    Browse the repository at this point in the history

  2. Rename CommitmentError variants

    @seanchen1991
    seanchen1991 committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    648dfd1 View commit details
    Browse the repository at this point in the history

  3. Clean up some DecodingError calls

    @seanchen1991
    seanchen1991 committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    eac1deb View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. Incorporate some PR feedback

    @seanchen1991
    seanchen1991 committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    0252e63 View commit details
    Browse the repository at this point in the history

  2. Incorporate more PR feedback

    @seanchen1991
    seanchen1991 committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    84f661d View commit details
    Browse the repository at this point in the history

  3. A bunch of DecodingError associated type changes

    @seanchen1991
    seanchen1991 committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    8add32b View commit details
    Browse the repository at this point in the history

  4. Eliminate a bunch of redundant map_err calls

    @seanchen1991
    seanchen1991 committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    0b00504 View commit details
    Browse the repository at this point in the history

  5. cargo fmt

    @seanchen1991
    seanchen1991 committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    d1ac0d2 View commit details
    Browse the repository at this point in the history

  6. Fix ics23 spec tests

    @seanchen1991
    seanchen1991 committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    919c7ae View commit details
    Browse the repository at this point in the history

  7. Fix a typo

    @seanchen1991
    seanchen1991 committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    103b24a View commit details
    Browse the repository at this point in the history

  8. Clean up some error messages

    @seanchen1991
    seanchen1991 committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    b7515b7 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Consolidate MismatchedTypeUrl and MismatchedEventKind variants

    @seanchen1991
    seanchen1991 committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    2aea7ce View commit details
    Browse the repository at this point in the history

  2. Miscellaneous clean up

    @seanchen1991
    seanchen1991 committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    9cec303 View commit details
    Browse the repository at this point in the history

  3. cargo fmt

    @seanchen1991
    seanchen1991 committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    7cebcf7 View commit details
    Browse the repository at this point in the history

  4. Remove unused CommitmentError variants

    @seanchen1991
    seanchen1991 committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    3d31fd5 View commit details
    Browse the repository at this point in the history

  5. Clean up errors to match ADR description

    @seanchen1991
    seanchen1991 committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    02f85a9 View commit details
    Browse the repository at this point in the history

  6. More clean up

    @seanchen1991
    seanchen1991 committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    fa7770c View commit details
    Browse the repository at this point in the history

  7. Add changelog entry

    @seanchen1991
    seanchen1991 committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    9d01b07 View commit details
    Browse the repository at this point in the history

  8. fix: remove now unused HeightError

    @Farhad-Shabani
    Farhad-Shabani committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    dbf1372 View commit details
    Browse the repository at this point in the history

  9. Clean up TimestampError

    @seanchen1991
    seanchen1991 committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    b98ae7c View commit details
    Browse the repository at this point in the history

  10. Merge branch 'imp/clean-up-string-variants' of https://github.com/cos… 

    …mos/ibc-rs into imp/clean-up-string-variants
    @seanchen1991
    seanchen1991 committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    bd6e694 View commit details
    Browse the repository at this point in the history