Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ICS24] Remove default value and implementation for PortId #951

Closed
Farhad-Shabani opened this issue Nov 8, 2023 · 0 comments · Fixed by #954
Closed

[ICS24] Remove default value and implementation for PortId #951

Farhad-Shabani opened this issue Nov 8, 2023 · 0 comments · Fixed by #954
Assignees
Labels
O: reliability Objective: cause to improve trustworthiness and consistent performing
Milestone

Comments

@Farhad-Shabani
Copy link
Member

Problem Statement

In our ics24_host codebase implementation, it is not appropriate to have a default value and implementation for the PortId.
The sole purpose of this default value is for testing. It functions correctly for local unit tests, but when we traverse through the router, our router exclusively accepts the transfer PortId as valid. For this, even for testing purposes, it is better to utilize transfer value to ensure more comprehensive and meaningful test coverage.

Proposal

Remove default value and implementation for PortId

@Farhad-Shabani Farhad-Shabani added the O: reliability Objective: cause to improve trustworthiness and consistent performing label Nov 8, 2023
@github-project-automation github-project-automation bot moved this to 📥 To Do in ibc-rs Nov 8, 2023
@Farhad-Shabani Farhad-Shabani self-assigned this Nov 8, 2023
@github-project-automation github-project-automation bot moved this from 📥 To Do to ✅ Done in ibc-rs Nov 10, 2023
@Farhad-Shabani Farhad-Shabani added this to the v0.48.0 milestone Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O: reliability Objective: cause to improve trustworthiness and consistent performing
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant