Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Make TYPE_URLs private #597

Closed
Farhad-Shabani opened this issue Apr 3, 2023 · 0 comments · Fixed by #656
Closed

[Core] Make TYPE_URLs private #597

Farhad-Shabani opened this issue Apr 3, 2023 · 0 comments · Fixed by #656
Assignees
@plafer
Labels
O: maintainability Objective: cause to ease modification, fault corrections and improve code understanding
Milestone
v0.40.0

Comments

@Farhad-Shabani
Copy link
Member

Improvement Summary

Raised in #588 as there is a discrepancy between the public exposure of upgrade client TYPE_URL and other TYPE_URLs
Context: #588 (comment)

Proposal

Make TYPE_URLs public only to the crate
(Should be addressed along with #324)
@Farhad-Shabani Farhad-Shabani added the O: maintainability Objective: cause to ease modification, fault corrections and improve code understanding label Apr 3, 2023
@Farhad-Shabani Farhad-Shabani moved this to 📥 To Do in ibc-rs Apr 3, 2023
@Farhad-Shabani Farhad-Shabani mentioned this issue Apr 3, 2023
Closed
7 tasks
@Farhad-Shabani Farhad-Shabani mentioned this issue May 5, 2023
Merged
7 tasks
@github-project-automation github-project-automation bot moved this from 📥 To Do to ✅ Done in ibc-rs May 5, 2023
@Farhad-Shabani Farhad-Shabani added this to the v0.40.0 milestone May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plafer plafer

Labels
O: maintainability Objective: cause to ease modification, fault corrections and improve code understanding
Projects
None yet
Milestone
v0.40.0
Development

Successfully merging a pull request may close this issue.

Properly define and document our public interface informalsystems/ibc-rs
2 participants
@plafer @Farhad-Shabani